keep“select target"for a while

[mike22]

first i must say thanks for making the tool.i have been using it for more than 1 month,it is quite fantastic,but i met some problems these days.it is just like follows.

fount new target--->
select target---->

.....2 minutes gone
.......
select the white hand warrior
then the bot begin to fight with the mob.
i have no idea what the bot is waiting for after it says"select target",and during that time,the "last message" keep changing with "500ms ago" around.it surely will low the speed,i hope anyone can help me with it,thanks

[bob]

can you tick the DEBUG option on the config page, and then post the log with the section where this is happening.

The log can be found in your Documents\pwnagebot folder.

and the Last Message refers to a specific message type received internally, and is not actually a guide to how often updates are being made (of which 3 or 4 threads are polling pretty much every 100ms)

[mike22]

thanks bob,i find the log and here it is.i copy both the problem part and something near it which maybe cares.

[2013-06-17 17:53:04.306] - [Info] Target is dead.
[2013-06-17 17:53:04.313] - [Info] XP earned: 448 - 10,840,354
[2013-06-17 17:53:04.314] - [Debug] Loot completed: success
[2013-06-17 17:53:04.328] - [Debug] Loot completed: success
[2013-06-17 17:53:04.341] - [Debug] Loot completed: success
[2013-06-17 17:53:04.427] - [Debug] Entering State: Rest.
[2013-06-17 17:53:04.483] - [Debug] Morale: 6986/7582 - 92.1%.
[2013-06-17 17:53:04.483] - [Debug] Power: 3567/3924 - 90.9%.
[2013-06-17 17:53:04.600] - [Debug] Entering State: Buff.
[2013-06-17 17:53:04.799] - [Debug] Entering State: Loot.
[2013-06-17 17:53:05.017] - [Debug] Entering State: FindTarget.
[2013-06-17 17:53:05.128] - [Debug] My Distance for MoveOnRange: 55.44
[2013-06-17 17:53:05.243] - [Debug] Entering State: MoveToGrindSpot.
[2013-06-17 17:53:05.301] - [Info] Currently in unmapped region. Moving to nearest mapped region.
[2013-06-17 17:53:05.771] - [Debug] Cast completed: failure
[2013-06-17 17:53:05.773] - [Debug] Cast completed: failure
[2013-06-17 17:53:07.798] - [Debug] Closest region (dist=25.7)
[2013-06-17 17:53:11.341] - [Debug] Grindspots Source: 1082073; Current: 2; Destination: 1082080.
[2013-06-17 17:53:15.036] - [Info] Found new target '[72] Dusk-hound (100%)' (0x52817384) - 46.2 away.
[2013-06-17 17:53:15.148] - [Debug] Entering State: GetInRange.
[2013-06-17 17:53:19.656] - [Debug] Entering State: Pull.
[2013-06-17 17:53:19.656] - [Info] Select target.
[2013-06-17 17:54:43.414] - [Info] Added: A 'Dusk-hound (0x52817384)' has aggro'd us.
[2013-06-17 17:54:44.165] - [Info] Selected Dusk-hound
[2013-06-17 17:54:44.324] - [Info] Found new aggro'd target 'X[72] Dusk-hound (43%)' - 2.8 away.
[2013-06-17 17:54:44.369] - [Info] Selected Dusk-hound
[2013-06-17 17:54:44.493] - [Debug] Entering State: Combat.
[2013-06-17 17:54:44.494] - [Info] Need to get in range.
[2013-06-17 17:54:44.635] - [Debug] Entering State: GetInRange.
[2013-06-17 17:54:44.695] - [Info] Found new aggro'd target 'X[72] Dusk-hound (43%)' - 2.8 away.
[2013-06-17 17:54:45.084] - [Info] Found new aggro'd target 'X[72] Dusk-hound (43%)' - 2.8 away.
[2013-06-17 17:54:45.582] - [Info] Found new aggro'd target 'X[72] Dusk-hound (43%)' - 2.8 away.
[2013-06-17 17:54:45.946] - [Info] Found new aggro'd target 'X[72] Dusk-hound (43%)' - 2.8 away.
[2013-06-17 17:54:46.999] - [Debug] Entering State: Pull.
[2013-06-17 17:54:47.143] - [Info] Found new aggro'd target 'X[72] Dusk-hound (43%)' - 1.1 away.
[2013-06-17 17:54:47.143] - [Info] Selected Dusk-hound
[2013-06-17 17:54:47.248] - [Debug] Entering State: Combat.
[2013-06-17 17:54:47.588] - [Debug] Performing action 'L04-Shield-swipe (0x7000305d)'.
[2013-06-17 17:54:49.311] - [Debug] Performing action 'L04-Shield-swipe (0x7000305d)'.
[2013-06-17 17:54:50.973] - [Debug] Performing action 'Bash (0x70003ee1)'.



the problem happens here
[2013-06-17 17:53:15.148] - [Debug] Entering State: GetInRange.
[2013-06-17 17:53:19.656] - [Debug] Entering State: Pull.
[2013-06-17 17:53:19.656] - [Info] Select target.
[2013-06-17 17:54:43.414] - [Info] Added: A 'Dusk-hound (0x52817384)' has aggro'd us.
[2013-06-17 17:54:44.165] - [Info] Selected Dusk-hound
[2013-06-17 17:54:44.324] - [Info] Found new aggro'd target 'X[72] Dusk-hound (43%)' - 2.8 away.
you can see at 17:53:19,the bot begins to stop,after a while a mob walks around to me and begins to attack the toon,about 2 miniutes later,the bot begins to fight back.

i also have 3 advices for the bot,i don't know other guys have the same problems as me,maybe it is my own computer's problem,but i sincerely hope they can help make the bot better:)
1\it is very hard to quit the the bot.
if i want to quit the bot,i usually use the Taskbar,it can be faster,and sometimes if i open the bot to the client again,the client will crash.
2\the cpu utilization
on my computer,the bot use 2 times cpu of the lotro client.i search the forums for"cpu" and got nothing,i am not sure others have the same problem as me
3\the page of config option varies between different kind of toons and different level
the settings which make me upset,like "midest"(in the class xml )"getinrange tolerance""melee distance""move forward range""move backward range""initial damage time""initial damage health left" "ignore invalid targets after""ignore valid targets for"
and also the pull range and grind range
i use the bot to upgrade the guardian,the config now is quite different from lvl20 when i first use them.and my hunter toon's config is surely different from my guardian too
if it is possible,i think it will be great if we all post the config settings on a topic,seprated with different class and levels.i think the config setting is as important as the class xml.

[gandalf39]

i also have 2 advices for the bot,i don't know other guys have the same problems as me,maybe it is my own computer's problem,but i sincerely hope they can help make the bot better:)
1\it is very hard to quit the the bot.
if i want to quit the bot,i usually use the Taskbar,it can be faster,and sometimes if i open the bot to the client again,the client will crash.
2\the cpu utilization
on my computer,the bot use 2 times cpu of the lotro client.i search the forums for"cpu" and got nothing,i am not sure others have the same problem as me
3\the page of config option varies between different kind of toons and different level
the settings which make me upset,like "midest"(in the class xml )"getinrange tolerance""melee distance""move forward range""move backward range""initial damage time""initial damage health left" "ignore invalid targets after""ignore valid targets for"
and also the pull range and grind range
i use the bot to upgrade the guardian,the config now is quite different from lvl20 when i first use them.and my hunter toon's config is surely different from my guardian too
if it is possible,i think it will be great if we all post the config settings on a topic,seprated with different class and levels.i think the config setting is as important as the class xml.

I have exactly the same issue with just stopping and standing there with the bot but it only happens on my LM who is in Lonelands atm. I cannot try with another script as the only one available is by shadowpanda which was Aeons ago. Maybe someone can share their working LM script?

[jonmale]

I have also noticed this, I tried increasing the 'ignore target after' time incase it was this even tried ignore target for 3 secs if it was in ignore list (not that the log shows it to be). It seems for me the bot 'lags' almost - so put it down to my inet connection. I simply kill the bot and reload at graveyard then restart - a 'quit' button would be a great idea as sometimes the bot crashes on the 'x' button and I loose any new map data if I have not manually saved. Perhaps a 'restart' or 'reload' bot button too?

[jonmale]

3\the page of config option varies between different kind of toons and different level
the settings which make me upset,like "midest"(in the class xml )"getinrange tolerance""melee distance""move forward range""move backward range""initial damage time""initial damage health left" "ignore invalid targets after""ignore valid targets for"
and also the pull range and grind range
i use the bot to upgrade the guardian,the config now is quite different from lvl20 when i first use them.and my hunter toon's config is surely different from my guardian too
if it is possible,i think it will be great if we all post the config settings on a topic,seprated with different class and levels.i think the config setting is as important as the class xml.

maybe I can help there:-

as I understand it,

ranged 'mindist' = 30 or 39 at later levels dependent on skills
melee 'mindist' = 1 or 2 at later levels dependent on skills/LI's

"getinrange tolerance" difference between mindist and this number I always leave at 1 for both ranged and melee successfully but for just melee you could change to 0.5.

moveforwardrange 2.3
movebackwardrange 1

duration for these i always use 150ms

meleedistance 2.4 (this is the melee range not 'ranged'!) or 3.4 again with LI's/skills that increase your mellee range

so with these settings the bot would fight 0.1 or 1.3 to 2.4 and pull at your pull range settings +/- your getinrange setting

"initial damage time" how long the bot will target (pull) go through its combat buffs etc then 'fire' - so this will vary but safe bet for most classes is 15 secs (a hunter for example would need more time than a champ)

"initial damage health left" always leave at 98% or 99% as some bosses have a buff which means you would want to dps adds 1st

"ignore invalid targets after" bots targeted but cant get in range or line of sight etc I tend to use 60 secs

"ignore valid targets for" this one I change allot (especially recently with bot 'bug' mentioned') generally i would ignore target for 60 secs - long enough to kill other target and move area, but if its in an open area for example and you have a large grind range then you could set this for 5 secs but if the mob is bugged this would loop the bot so only use if you can monitor the bot in this eventuality. 60 secs or 120 secs is wisest setting if unattended.

think thats how it works hopefully bob or someone can correct me if im wrong

also I tend to use cooldown '0' on most skills as with LI's reducing the cd time on skills I find this the easiest option to use when skill is avail - dont use '0' on pots or food or hunter focus etc though for example lol.

[bob]

First things.

I assume that lotro is running as Admin. Lotrobot will elevate itself.

Make sure that lotrobot.exe and lotroclient.exe is excluded from any Antivirus/Antimalware scanning. The only time I've seen lags like that is when Microsoft Security Essentials was kicking off a scan everytime lotrobot did anthing.

If that doesn't help, then it would be helpful if you could monitor what else if going on at the time on your computer.



Onto your other concerns (feedback is great, and is always welcome).
Config Page
The items on the Config page are stored in the Profile, so each Profile you create the settings can be different. In some cases the settings should be different depending on whether you have a melee or ranged character. The level of the character shouldn't make much difference (although there are some settings which may be more applicable to a location set than an overall profile value).

Every time you create a new profile, the settings will be set to the defaults. Unfortunately these may not be greate for a specific class of any time, but somewhere in the middle.

The default settings that may affect different classes is always a topic of debate, and I'm afraid there is no easy solution to it. There is also some variability in each users experience as to what works best for them.

CPU
Yes the cpu usage is higher than lotro itself. Performance tests show the majority of CPU time is spent reading the lotroclient memory to check current location, character details, and the all important mob list, amongst other things. Work is being done to lower cpu usage. For example, instead of polling the whole mob list every time, we just get notified of the add/remove of the mob to the list. This requires different hooks, and requires someone to find them, which is not a widely available skill (you are more then welcome to help out if you know how).

Quit
Make sure that the bot is stopped before trying to close. If it is running then it may not close down properly, and likely corrupt files.

Also, the taskbar close method is not specifically catered for. In theory it should be the same as closing the X from the form, in reality there is a bit of a hacky code path in the WinAPI for it and the behaviour is slightly different. This means it may not be removing the injected DLL properly from lotro, thus when you try and load up again, a crash occurs because your're already injected.

Worth noting that there seem to be a couple of other unrelated issues, which mean that the shutdown of the bot is not working well if they occur. This includes the mapping stopping if you get into fights while trying to setup a grind path.


Config settings
Yes, I'd like a button to copy config settings to paste directly here. As it is you can get them from the Profile xml file, but this does require more than one click. Also this implies that the bot can run without lotro. This is a feature which is coming, albeit slowly.



Anyway, all kind of non answers, but the good side of it is, that these items are being looked at. If you have some ideas of how you would prefer the layout/configuration items to function, then by all means, post them here, and it will always be considered.

[mike22]

Thanks bob,i appreciate your help very much.if i get any good idea about the bot,i will post them here.
And thank u jonmale

[bob]

Also, looking back at your original post, make sure your Pull Range on the location set is the same as or slightly less than your highest range skill that is configured.

e.g. for Hunter, whose range is generally 40 for skills, set this to 39.
For an RK, set it to 19
For a Champion, then pull range is generally going to be 2.5 unless you have a long range skill that it can used first anyway (I used throwing daggers on one, which was reasonably effective at getting a mobs attention - run out quick though)

[fruithustler]

http://rotko.net/ftpbox/Web-Interface-m ... agebot.png
http://rotko.net/ftpbox/Web-Interface-m ... gebot2.png

i keep dying coz out of range, how to fix this? Are my melee range values the problem and if so what would be better for champion to rock?

EDIT: tried also jonmale values but still dying against creeps which hit from over 2.5 range
E2: now i have bow and it´s not about range anymore, my character just doesnt attack creeps back even they are hitting me, what to do?
E3: okay realized mindist was 4 for champion :/ probably the problem